Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Ricochet Refresh.app" v3.0.10 #111995

Merged
merged 5 commits into from Oct 6, 2021

Conversation

m-simonelli
Copy link
Contributor

@m-simonelli m-simonelli commented Oct 2, 2021

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask <cask> worked successfully.
  • brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Hi
We're looking to get Ricochet Refresh integrated into homebrew.
Fixed, see comment. One issue was encountered when running brew audit --cask ricochet-refresh, see output:

noone@noone homebrew-cask % brew audit --new-cask ricochet-refresh
audit for ricochet-refresh: failed
 - exception while auditing ricochet-refresh: undefined method `downcase' for nil:NilClass
Error: 1 problem in 1 cask detected
noone@noone homebrew-cask % uname -a
Darwin noone.modem 20.3.0 Darwin Kernel Version 20.3.0: Thu Jan 21 00:06:51 PST 2021; root:xnu-7195.81.3~1/RELEASE_ARM64_T8101 x86_64
noone@noone homebrew-cask %

Not sure if this is an error on my part or if it's a bug in brew audit (I tried to follow the docs and keep it fairly simple, but granted this is my first time packaging for homebrew).

Cheers,
M

@m-simonelli
Copy link
Contributor Author

Update:
brew audit runs successfully - Just had to add a https://www. to the start of the homepage link

Cheers,
M

@miccal miccal added the awaiting maintainer feedback Issue needs response from a maintainer. label Oct 4, 2021
@gdams
Copy link
Contributor

gdams commented Oct 4, 2021

Looking at the README.md it clearly states "WORK IN PROGRESS PROJECT REPOSITORY - NOT FOR PRODUCTION USE".

I also note that the GitHub repository is a fork of https://github.com/ricochet-im/ricochet?

@gdams gdams added awaiting user reply Issue needs response from a user. and removed awaiting maintainer feedback Issue needs response from a maintainer. labels Oct 4, 2021
@m-simonelli
Copy link
Contributor Author

m-simonelli commented Oct 5, 2021

cc @pospeselr we need to fix this
@gdams regarding both points, see ricochet-im/ricochet#613
TLDR Ricochet, the original project, is essentially dead so we at blueprint forked the code to "refresh" it, hence "ricochet refresh" was born.
We're stable and have a release on the website - the readme note is more of a documentation lagging behind reality as usual

Cheers,
M

@m-simonelli
Copy link
Contributor Author

Update: see tentative update README

@gdams gdams added awaiting maintainer feedback Issue needs response from a maintainer. and removed awaiting user reply Issue needs response from a user. labels Oct 5, 2021
@gdams
Copy link
Contributor

gdams commented Oct 5, 2021

TLDR Ricochet, the original project, is essentially dead so we at blueprint forked the code to "refresh" it, hence "ricochet refresh" was born.

If the original repo is abandoned and upstream is therefore never going to merge back it might be worth un-forking that repository?

@m-simonelli
Copy link
Contributor Author

TLDR Ricochet, the original project, is essentially dead so we at blueprint forked the code to "refresh" it, hence "ricochet refresh" was born.

If the original repo is abandoned and upstream is therefore never going to merge back it might be worth un-forking that repository?

Not really in my control, unfortunately, and does it particularly matter? It signals that this project is in fact a child project of the original ricochet (I mean we even gave it a different name, it's not like we're trying to compete with a project of the same name)

Cheers,
M

@miccal
Copy link
Member

miccal commented Oct 6, 2021

Looks fine to me, thank you @m-simonelli.

@miccal miccal merged commit 15edff6 into Homebrew:master Oct 6, 2021
@miccal miccal removed the awaiting maintainer feedback Issue needs response from a maintainer. label Oct 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants