Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oauth2 web flow #953

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

jabdoa2
Copy link
Contributor

@jabdoa2 jabdoa2 commented Jul 25, 2023

No description provided.

@HenriWahl
Copy link
Owner

As being on vacation the review will be a little bit delayed.

@jabdoa2
Copy link
Contributor Author

jabdoa2 commented Jul 30, 2023

As being on vacation the review will be a little bit delayed.

Dont worry. I will be on vacations as well.

@HenriWahl
Copy link
Owner

@jabdoa2 just tell me when you are finally done and I might review

@jabdoa2
Copy link
Contributor Author

jabdoa2 commented Aug 25, 2023

I have used it for a few weeks now and it works well. So ready for review :-).

@HenriWahl
Copy link
Owner

@jabdoa2 sorry for the late reply.

I do not fully understand in how far this is a server type?

@jabdoa2
Copy link
Contributor Author

jabdoa2 commented Sep 20, 2023

@jabdoa2 sorry for the late reply.

I do not fully understand in how far this is a server type?

This is a type of authentication. It works similar to: https://github.com/int128/kubelogin/blob/master/docs/credential-plugin-diagram.svg (from https://github.com/int128/kubelogin). This allows you to use almost any cooperate single-sign on solution (such a keycloak, google, azure, okta, facebook, github and may more). Also enables 2FA or PKI solutions.

I can show this to you if you like to see it in action. We can schedule a call if you like (i am GMT+2).

Looks like I accidentally included a bugfix for the notification server in this PR. I can rebase if that helps.

@HenriWahl
Copy link
Owner

Yes, this is why I am wondering. Maybe we'll find a better place to put that logic into, as the Servers directory is full of servers.

@HenriWahl
Copy link
Owner

I am going to test the functionality with local Keycloak setup.

@jabdoa2
Copy link
Contributor Author

jabdoa2 commented Oct 10, 2023

Let me know if you need any help with setting up a local keycloak. I guess you could also use the testground at https://openidconnect.net/ as a provider. For your Icingaweb (or any other web based solution) you need Apache with mod_auth_oidc (or any other similar extension) or nginx with an oidc extension.

@jan-kantert
Copy link

Is there anything I could help here?

@HenriWahl
Copy link
Owner

@jan-kantert can you test it? And as mentioned to @jabdoa2, I would not sort this functionality into Servers.

@matt-horwood-mayden
Copy link

Can I test this please? But I dont have the brains to build from source 😞

@matt-horwood-mayden
Copy link

Can I test this please? But I dont have the brains to build from source 😞

I have built this and my current config now doesnt work, get the below errors

QLayout: Attempting to add QLayout "" to StatusWindow "", which already has a layout
QLayout: Attempting to add QLayout "" to StatusWindow "", which already has a layout
QLayout: Attempting to add QLayout "" to StatusWindow "", which already has a layout
QLayout: Attempting to add QLayout "" to StatusWindow "", which already has a layout
QLayout: Attempting to add QLayout "" to StatusWindow "", which already has a layout

@mhzawadi
Copy link

I have a working keycloak setup and would love to test this out

@jabdoa2
Copy link
Contributor Author

jabdoa2 commented May 28, 2024

Can I test this please? But I dont have the brains to build from source 😞

I have built this and my current config now doesnt work, get the below errors

QLayout: Attempting to add QLayout "" to StatusWindow "", which already has a layout
QLayout: Attempting to add QLayout "" to StatusWindow "", which already has a layout
QLayout: Attempting to add QLayout "" to StatusWindow "", which already has a layout
QLayout: Attempting to add QLayout "" to StatusWindow "", which already has a layout
QLayout: Attempting to add QLayout "" to StatusWindow "", which already has a layout

When do you get that error? When nagstamon runs? When compiling?

@mhzawadi
Copy link

I get the error running nagstamon on the command line, it runs kind of fine from a compiled app. But it fails to get any data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants