data state restoration #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimotheeMickus
force-pushed
the
feats/data-restoration
branch
from
edaa78b
to
ec347bc
Compare
|
also embarks a minor debug on update_vocab being only partially removed (following #61) |
jrvc
reviewed
May 22, 2024
mammoth/inputters/dataset.py
Outdated
| @@ -162,13 +184,13 @@ def _cast(example_dict): | |||
| if self.transforms is not None else lambda x: x | |||
| ), | |||
| stride=self.stride, | |||
| offset=self.offset, | |||
| offset=offset, | |||
| ) | |||
| examples = map(_cast, examples) | |||
| yield from examples | |||
|
|
|||
| # FIXME: some RNN archs require sorting src's by length | |||
There was a problem hiding this comment.
Out of this PR concenrs... do we still support RNNs? if not, we can just delete this
There was a problem hiding this comment.
no, we no longer support RNNs. the move is to externalize transformer variantsvia lucidrains (see #56). Will remove the comment
jrvc
reviewed
May 22, 2024
mammoth/models/model_saver.py
Outdated
| @@ -95,12 +96,14 @@ def save(self, step, moving_average=None): | |||
| self._rm_checkpoint(todel) | |||
| self.checkpoint_queue.append(chkpt_names) | |||
|
|
|||
| def _save(self, step): | |||
| def _save(self, step, save_model, data_state, device_context): | |||
| """Save a resumable checkpoint. | |||
|
|
|||
| Args: | |||
| step (int): step number | |||
| model (nn.Module): torch model to save | |||
There was a problem hiding this comment.
missing: save_model (type): description
There was a problem hiding this comment.
yeah, i think it was renamed from model to save_model? not sure why. will fix that.
added 2 commits
May 22, 2024 17:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #63 .
same idea as v2, didn't bother porting from it.
does not embark bucket states, although this could maybe be done by picking the line indices from all examples in the reservoir. Would come at a (potentially high) communication overhead cost.