Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data state restoration #63

Closed
1 of 2 tasks
TimotheeMickus opened this issue Mar 16, 2024 · 0 comments · Fixed by #64
Closed
1 of 2 tasks

Data state restoration #63

TimotheeMickus opened this issue Mar 16, 2024 · 0 comments · Fixed by #64
Labels
enhancement New feature or request

Comments

@TimotheeMickus
Copy link
Collaborator

TimotheeMickus commented Mar 16, 2024

Currently, the --train_from option does not include means of restoring corpora states, hence training resumes from the beginning of the bitexts. This entails resumed models are training on a subset of the available data, unless some manual shuffling is done between each resumption.

Fixes (partially implemented on V2, but never ported here

  • add a line index as files are read, pass it along when collating batches, and skip up til this line index upon training resumption
  • a more complex refactoring is needed to save the dataloader state, as it would involve communicating all examples in the reservoir — which would be much more costly to communicate.

CC @jrvc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant