Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a function setHeight to modify Text Height after initialization #423

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Create a function setHeight to modify Text Height after initialization #423

wants to merge 2 commits into from

Conversation

wselken
Copy link
Contributor

@wselken wselken commented Nov 18, 2016

No description provided.

@bendmorris
Copy link
Member

👍 good addition, I'm going to do some testing of this later tonight to make sure there aren't edge cases.

If you have a second please rename inHeight to height? That's not a naming convention this project uses. Otherwise I'll do that manually when I merge.

@bendmorris
Copy link
Member

Are you using this? Can you provide a simple demo that shows this working? I suspect _height might also need to be set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wselken @bendmorris