Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy to a different dir to fix hot upgrades #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manukall
Copy link
Contributor

this still uses /srv/apps as directory for the running app.mostly because i already started when i saw your comment. i've seen this pattern often before though and the directory is owned by the deployer user.

upgrading the role requires manually stopping your app once, though. (stop app, run ansible setup). after that, everything work's automatically again.

@HashNuke
Copy link
Owner

@manukall Thank you. I'll make some more changes tomorrow and merge these.

@manukall
Copy link
Contributor Author

@HashNuke any news on this? i also have a PR that enables gzip compression, but i realized that my branch for that also includes the changes here...

@HashNuke
Copy link
Owner

@manukall I have some changes too. I'll merge this in and make my changes tomorrow.

@manukall
Copy link
Contributor Author

@HashNuke thanks! i noticed that the order of the steps in the "restart" branch could be changed to not have that much downtime now. maybe that would be a nice improvement.

@HashNuke
Copy link
Owner

@manukall sure. That would be very helpful. I'll work on this PR and then you can brach out from latest master to work on that so that there are no conflicts.

@HashNuke
Copy link
Owner

HashNuke commented Sep 1, 2015

@manukall I've been working on the hot-reload-fix branch on some changes.

Right now using, $HOME/srv/{{ app_name }} for deployer user to serve apps (so when someone logs in as deployer they see the whole structure when they just ls. Yet test to test my changes. I'll do it today.

@manukall
Copy link
Contributor Author

manukall commented Sep 1, 2015

cool.
it looks as if you're keeping the deploy_path configurable. that's great, because then i might be able to switch back to your version. i'm already in production and don't want to change directories on my live server.
also, i noticed you got rid of my hack for the app_version. i did that, because i have some output when my app starts. so you're version here won't work for me and possibly others.
i also have some more changes that i might be able to create pull requests for later.

thanks again!

@HashNuke
Copy link
Owner

HashNuke commented Sep 1, 2015

@manukall Oh makes sense. I forgot to ask you about that. I'm sure there are others that output stuff too. I'll revert to the RELEASE_VERSION hack.

@HashNuke
Copy link
Owner

HashNuke commented Sep 1, 2015

@manukall reverted to your hack for app version. If you happen to make a deploy with the hot-reload-fix branch, do let me know how it goes.

@rubytree
Copy link
Contributor

rubytree commented Jan 3, 2016

@HashNuke Has this been resolved?

@HashNuke
Copy link
Owner

HashNuke commented Jan 4, 2016

@rubytree Not yet. I'll do it this weekend for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants