Custom disk cache and memory cache #292
Conversation
| } | ||
| } | ||
|
|
||
| public class HanekeCache<T: DataConvertible, DiskCacheT, MemoryCacheT where T.Result == T, T : DataRepresentable, DiskCacheT: DiskCache, MemoryCacheT: NSCache> { |
There was a problem hiding this comment.
Having MemoryCacheT: NSCache as generic constraint means that the memory cache must be a NSCache subclass, while subclassing NSCache might be not the main preference of a developer while building a custom memory caching system. I recommend to protocols DiskCache and MemoryCache to give complete implementation freedom to the developer.
There was a problem hiding this comment.
you are correct. but I need someone to ensure that this PR is going to be merged before I spend time on this.
There was a problem hiding this comment.
Seems fair. I'm not the maintainer so I cannot give you this guarantee, but the swift 4 branch was just merged.
|
if we can preserve compatibility I think there is good chances that we merge it |
I have moved DiskCache and NSCache to the arguments of the generic class Cache, which is a subclass of HanekeCache.
The users who want to customize DiskCache or NSCache can use HanekeCache with custom implementation (a subclass) of DiskCache and NSCache