Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added balancing groups and common group receiver #2885

Draft
wants to merge 82 commits into
base: master
Choose a base branch
from

Conversation

ethouris
Copy link
Collaborator

No description provided.

Mikołaj Małecki and others added 30 commits July 29, 2022 12:44
…. Fixed epoll usage for reception for groups.
{
LOGC(rbuflog.Warn, log << "CRcvBuffer.readMessage(): nothing to read. Ignored isRcvDataReady() result?");
return 0;
}

const int readPos = canReadInOrder ? m_iStartPos : m_iFirstReadableOutOfOrder;
//const bool canReadInOrder = m_iFirstNonreadPos != m_iStartPos;

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Comment on lines +957 to +962
/*
int32_t getOldestRcvSeqNo() const
{
return m_pRcvBuffer->getStartSeqNo();
}
*/

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@@ -126,6 +127,7 @@
for (int i = 0; i < iNumUnits; ++i)
{
tempu[i].m_bTaken = false;
tempu[i].m_pParentQueue = this;

Check warning

Code scanning / CodeQL

Local variable address stored in non-local memory Warning

A stack address which arrived via a
parameter
may be assigned to a non-local variable.
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 78.98734% with 83 lines in your changes are missing coverage. Please review.

Project coverage is 63.84%. Comparing base (16cb043) to head (328c359).
Report is 4 commits behind head on master.

Files Patch % Lines
srtcore/buffer_rcv.cpp 71.93% 55 Missing ⚠️
srtcore/group.h 66.66% 12 Missing ⚠️
srtcore/list.cpp 94.56% 5 Missing ⚠️
srtcore/buffer_rcv.h 50.00% 4 Missing ⚠️
srtcore/api.cpp 50.00% 2 Missing ⚠️
srtcore/group_common.cpp 50.00% 2 Missing ⚠️
srtcore/group_common.h 0.00% 2 Missing ⚠️
srtcore/queue.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2885      +/-   ##
==========================================
- Coverage   64.79%   63.84%   -0.96%     
==========================================
  Files         101      102       +1     
  Lines       17482    18322     +840     
==========================================
+ Hits        11328    11698     +370     
- Misses       6154     6624     +470     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxsharabayko maxsharabayko added this to the Major milestone Mar 6, 2024
@maxsharabayko maxsharabayko added Type: Enhancement Indicates new feature requests [core] Area: Changes in SRT library core labels Mar 6, 2024
@Dawiducik
Copy link

That feature looks so cool! Is there any timeline when the next major version of SRT will be published along with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants