Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCV erase undecrypted packet instead of dropping. #2649

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

RCV erase undecrypted packet instead of dropping. #2649

wants to merge 1 commit into from

Conversation

maxsharabayko
Copy link
Collaborator

Eras the packet from the RCV buffer on decryption failure. However, this also requires re-adding the packet to the loss list.

TODO

  • Erasing the packet means it has to be added back to the loss list.

Addresses #2626

@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Feb 6, 2023
@maxsharabayko maxsharabayko added this to the v1.5.2 milestone Feb 6, 2023
This was referenced Feb 8, 2023
Merged
Open
@maxsharabayko maxsharabayko modified the milestones: v1.5.2, v1.6.0 Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
v1.5.4
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@maxsharabayko