Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repurposed the pktRcvAvgBelatedTime to trace the unique packet delay. #2540

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Nov 15, 2022

Fixed statistics related to pktRcvAvgBelatedTime and pktRcvBelated.

  1. The pktRcvAvgBelatedTime has changed the purpose, as previous one was useless and meaningless, while the new meaining partially matches the name. This means now: the average distance between ETS and arrival time. ETS is the expected arrival time which is identical to arrival time for the very first data packet and as the calculation of the TsbPdTime currently involves the latency setting, this time is calculated basing on the TsbPdTime by decreasing it by latency, that is, it's the time when particular packet, stating by its timestamp, would arrive if the network traveling time was identical to the one of the very first data packet. This value can be used in trial transmissions to have idea how much on average the packet could be delayed in the network more than expected, as this value eats up time reserved by latency. This will be helpful in better shaping the latency settings to avoid dropped packets due to too little time reserved for retransmission. Note that this stat doesn't trace the extra time eaten up by retransmitted packets (for that purpose additional stats can be added).
  2. The stat pktRcvBelated that calculates packets that were rejected due to being received too late, was doing it a bit incorrectly. This is now calculated for every packet that has a sequence number in the past for the buffer. This still doesn't state whether a packet was received useful (that is, if this isn't a duplicated packet that was retransmitted uselessly).

@ethouris ethouris added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant