Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SwiftUI Label #474

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Add SwiftUI Label #474

wants to merge 3 commits into from

Conversation

vincentbanguyen
Copy link
Contributor

Description

Added HILabel in SwiftUI
Missing some border and shadow cases, but can come back to it if encounter those cases

@vincentbanguyen
Add SwiftUI Label
e893932 
Missing some border and shadow cases, but can come back to it if encounter those cases
@lasyaneti
Copy link
Contributor

Please resolve all of the following lint violations

  • Trailing Whitespace Violation
  • Colon Spacing Violation
  • Trailing Comma Violation
  • File Header Violation
  • Opening Brace Spacing Violation
  • Void Function in Ternary Violation
  • Function Body Length Violation
  • Line Length Violation
  • For Where Violation

And deprecations

  • Change Class to AnyObject

Look at the build log for the exact warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffkim2001 jeffkim2001 Awaiting requested review from jeffkim2001

@ashayp22 ashayp22 Awaiting requested review from ashayp22 ashayp22 is a code owner

@lasyaneti lasyaneti Awaiting requested review from lasyaneti lasyaneti is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vincentbanguyen @lasyaneti