Added Staff Shift endpoints #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasyaneti
reviewed
Dec 11, 2023
lasyaneti
approved these changes
Dec 11, 2023
lasyaneti
reviewed
Dec 11, 2023
lasyaneti
reviewed
Dec 12, 2023
lasyaneti
requested changes
Dec 12, 2023
AydanPirani
reviewed
Dec 17, 2023
| const payload: JwtPayload = res.locals.payload as JwtPayload; | ||
|
|
||
| if (!hasStaffPerms(payload)) { | ||
| if (!hasAdminPerms(payload)) { |
There was a problem hiding this comment.
Why change this? All staff should be able to see staff events
Hierarchy should be like this:
non-staff: no access
staff: access to their own shifts + all general staff events
admins: access to staff shifts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/staff/shiftreturns dummy data at the moment, we are working on bugfixing a timeout request issue but wanted to push out an MVP.