Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Tests #122

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Event Tests #122

wants to merge 9 commits into from

Conversation

AydanPirani
Copy link
Collaborator

Will contain comprehensive tests for the events service

Copy link
Member

@Timothy-Gonzalez Timothy-Gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not giving a formal review yet because this is still in progress, but here's two small things for now. General heuristic for tests is look at coverage and see what isn't covered - and make sure you're covering those edge cases.

sponsor: "Example sponsor",
eventType: "OTHER",
points: 0,
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np: Use satisfies to verify correctness

expect(response).toHaveProperty("error");
});

it("cannot be accessed by staff", async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need to test for every level - just test the level below what is expect (staff for admin only, attendee for staff only, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants