Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "auth: Always check token.exp when launch game"" #3040

Closed

Conversation

burningtnt
Copy link
Member

@burningtnt burningtnt commented May 10, 2024

Reverts #2907

Close #2048

@zkitefly
Copy link
Member

zkitefly commented May 10, 2024

我不太认为要 revert

我们还不知道上次导致这个错误的原因

可能需要进一步测试才能合并

@zkitefly
Copy link
Member

测试结果

分别下载个版本,登录微软账户,然后点击刷新按钮

本 PR 加上 token

出现问题

image

hmcl-exported-logs-2024-05-11T22-40-29.log

eadfff3

没有问题

hmcl-exported-logs-2024-05-11T22-46-00.log

cb4cd69eadfff3 的上一个 commit)

出现问题

image

hmcl-exported-logs-2024-05-11T22-47-49.log

也就是说,#2642 本身存在问题,希望 @zyxkad 能看一看

@zyxkad
Copy link
Contributor

zyxkad commented May 11, 2024

也就是说,#2642 本身存在问题,希望 @zyxkad 能看一看

不是,我的PR没有问题,但是有人把我的PR revert了

@zyxkad
Copy link
Contributor

zyxkad commented May 11, 2024

#2908

@zyxkad
Copy link
Contributor

zyxkad commented May 11, 2024

好吧我再看看

@zkitefly
Copy link
Member

刷新后会出现该问题

[22:47:32] [org.jackhuang.hmcl.task.AsyncTaskExecutor.lambda$start$1/WARNING] An exception occurred in task execution
org.jackhuang.hmcl.auth.yggdrasil.RemoteAuthenticationException: invalid_grant: AADSTS50196: The server terminated an operation because it encountered a client request loop. Please contact your app vendor. Trace ID: d9e6dd62-11e3-4363-aa5e-1ae057c96101 Correlation ID: d37a10ae-a1b5-412f-bfb9-a92e47e8886c Timestamp: 2024-05-11 14:47:32Z: 
	at org.jackhuang.hmcl.auth.OAuth.handleErrorResponse(OAuth.java:190)
	at org.jackhuang.hmcl.auth.OAuth.refresh(OAuth.java:167)
	at org.jackhuang.hmcl.auth.microsoft.MicrosoftService.refresh(MicrosoftService.java:85)
	at org.jackhuang.hmcl.auth.microsoft.MicrosoftAccount.logIn(MicrosoftAccount.java:88)
	at org.jackhuang.hmcl.ui.account.AccountListItem.lambda$refreshAsync$0(AccountListItem.java:105)
	at org.jackhuang.hmcl.util.function.ExceptionalRunnable.lambda$toCallable$0(ExceptionalRunnable.java:32)
	at org.jackhuang.hmcl.task.Task$SimpleTask.execute(Task.java:1025)
	at org.jackhuang.hmcl.task.AsyncTaskExecutor.lambda$executeNormalTask$22(AsyncTaskExecutor.java:245)
	at org.jackhuang.hmcl.util.Lang.lambda$wrap$2(Lang.java:291)
	at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804)
	at java.base/java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1796)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)

@burningtnt burningtnt closed this May 12, 2024
@burningtnt burningtnt deleted the revert-2907-revert-2642-javafx branch May 15, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants