Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support #3000: Support neoforge.mods.toml #3031

Merged
merged 4 commits into from May 15, 2024
Merged

Support #3000: Support neoforge.mods.toml #3031

merged 4 commits into from May 15, 2024

Conversation

burningtnt
Copy link
Member

Close #3000

3gf8jv4dv
3gf8jv4dv approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested using the build generated from this PR.

The identification of modloaders looks good. Update checks for most mods look fine.

Preview

Please ignore the Radium in the first picture, it does not fill in the dependencies information in neoforge.mods.toml according to the specification.

00

01

@burningtnt burningtnt mentioned this pull request May 6, 2024
Closed
@burningtnt
Copy link
Member Author

Fix #2371

image
It works, anyway...

@burningtnt
Copy link
Member Author

Please ignore the Radium in the first picture, it does not fill in the dependencies information in neoforge.mods.toml according to the specification.

I've hade some changes to adapt to these cases ... Although they are bugs, but, for maxinum compatibility, I have to provide fallback codes.

@3gf8jv4dv
Copy link
Contributor

I've hade some changes to adapt to these cases ... Although they are bugs, but, for maxinum compatibility, I have to provide fallback codes.

What you said makes sense. I tried checking to update the 1.20.1 version of embeddium and everything worked fine.

@Glavo Glavo changed the title Support #3000 Support #3000: Support neoforge.mods.toml May 15, 2024
@Glavo Glavo merged commit af37194 into HMCL-dev:main May 15, 2024
2 checks passed
@burningtnt burningtnt deleted the support3000/neoforge-mods-toml branch May 15, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Glavo Glavo Glavo approved these changes

@3gf8jv4dv 3gf8jv4dv 3gf8jv4dv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support neoforge.mods.toml
3 participants
@burningtnt @3gf8jv4dv @Glavo