New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 432 gameid for curseforge fingerprints matching #3022
Open
z0z0r4
wants to merge
1
commit into
HMCL-dev:main
Choose a base branch
from
z0z0r4:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burningtnt
suggested changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有问题
[22:17:40] [org.jackhuang.hmcl.task.AsyncTaskExecutor.lambda$start$1/WARNING] An exception occurred in task execution
java.io.IOException: Server returned HTTP response code: 403 for URL: https://api.curseforge.com/v1/fingerprints/432
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
at java.base/sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1980)
at java.base/sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1975)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at java.base/sun.net.www.protocol.http.HttpURLConnection.getChainedException(HttpURLConnection.java:1974)
at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1536)
at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1520)
at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:250)
at org.jackhuang.hmcl.util.io.NetworkUtils.readData(NetworkUtils.java:245)
at org.jackhuang.hmcl.util.io.HttpRequest$HttpPostRequest.lambda$getString$0(HttpRequest.java:195)
at org.jackhuang.hmcl.util.io.HttpRequest.getStringWithRetry(HttpRequest.java:223)
at org.jackhuang.hmcl.util.io.HttpRequest.access$100(HttpRequest.java:46)
at org.jackhuang.hmcl.util.io.HttpRequest$HttpPostRequest.getString(HttpRequest.java:182)
at org.jackhuang.hmcl.util.io.HttpRequest.getJson(HttpRequest.java:105)
at org.jackhuang.hmcl.mod.curse.CurseForgeRemoteModRepository.getRemoteVersionByLocalFile(CurseForgeRemoteModRepository.java:162)
at org.jackhuang.hmcl.ui.versions.ModListPageSkin$ModInfoDialog.lambda$new$4(ModListPageSkin.java:335)
at org.jackhuang.hmcl.util.function.ExceptionalRunnable.lambda$toCallable$0(ExceptionalRunnable.java:32)
at org.jackhuang.hmcl.task.Task$SimpleTask.execute(Task.java:1025)
at org.jackhuang.hmcl.task.AsyncTaskExecutor.lambda$executeNormalTask$22(AsyncTaskExecutor.java:244)
at org.jackhuang.hmcl.util.Lang.lambda$wrap$2(Lang.java:291)
at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1736)
at java.base/java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1728)
at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183)
Caused by: java.io.IOException: Server returned HTTP response code: 403 for URL: https://api.curseforge.com/v1/fingerprints/432
at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1924)
at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1520)
at java.base/java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:527)
at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:334)
at org.jackhuang.hmcl.util.io.HttpRequest$HttpPostRequest.lambda$getString$0(HttpRequest.java:193)
... 17 more
403 不是我这个问题吧? |
在主线上并没有相关问题 |
不能理解, 你这测试的时候 headers有加 xapikey 吗? |
我知道了…… 我开了安全配置,别的仓库代码过来默认是没有环境变量的。我重测
在 2024-05-17 12:15:14,z0z0r4 ***@***.***> 写道:
不能理解, 你这测试的时候 headers有加 xapikey 吗?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
432 is gameid for minecraft
https://docs.curseforge.com/#get-fingerprints-matches-by-game-id
https://github.com/Hex-Dragon/PCL2/blob/d682b598032bc4c7e3b1367cae4d51d037007ae9/Plain%20Craft%20Launcher%202/Modules/Minecraft/ModMod.vb#L1029-L1030