New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
重构 Java 管理 #2988
base: main
Are you sure you want to change the base?
重构 Java 管理 #2988
Conversation
HMCLCore/src/main/java/org/jackhuang/hmcl/game/JavaVersionConstraint.java
Show resolved
Hide resolved
HMCLCore/src/test/java/org/jackhuang/hmcl/game/JavaVersionConstraintTest.java
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
慢慢搞,这个功能还有很多优化空间~ |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Although subsequent commits tried to solve this problem, they seemed to only apply to Release versions. some snapshots and pre-release versions still give error messages. |
Really helpful testing! Thanks. |
HMCL will try to read Java information in two ways:
There are some problems with the first way:
But this way is much faster (no need to run these Java), so it will be used as the primary way to read Java information. What you are experiencing is because its I have now done something to optimize this behavior and this issue should be resolved after you uninstall and reinstall Java. There may still be some edge cases where similar problems arise, but I don't think it's worth the extra effort to solve them. |
Use this build. In some cases, when selecting a specific Java binary that already exists, the box to the right of Specify Java Version will be filled with characters even though the user cannot enter it. |
Feature Request: Optimize the dialog when HMCL is launched with Java 8-10 by providing a direct button to download Java 11/17 See: #3007 |
Feature Request: Bundle a json into HMCL like openjfx-dependencies.json, which provides more JRE versions such as 1.8_41, 1.8_312 and 11.x.x and supports more OS. We do need to download these versions, as #3049 requires these features. |
} | ||
|
||
@Nullable | ||
public static JavaRuntime findSuitableJava(Collection<JavaRuntime> javaRuntimes, GameVersionNumber gameVersion, Version version) throws InterruptedException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method never throws InterruptedException.
暂未测试,晚点再说。