Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support neoforge.mods.toml #3000

Closed
3gf8jv4dv opened this issue Apr 19, 2024 · 1 comment · Fixed by #3031
Closed

[Feature] Support neoforge.mods.toml #3000

3gf8jv4dv opened this issue Apr 19, 2024 · 1 comment · Fixed by #3031
Labels
enhancement
Milestone
Release 3.5.8

Comments

@3gf8jv4dv
Copy link
Contributor

描述 | Description

When NeoForge 20.5 is released with Minecraft 1.20.5, the launcher supports reading neoforge.mods.toml.

原因 | Reason

According to neoforged/FancyModLoader#100 and a draft of their upcoming 1.20.5 blog post, the NeoForge maintainers are preparing to rename mods.toml to neoforge.mods.toml. This will take effect in NeoForge 20.5.

As the official release of Minecraft 1.20.5 approaches , I thought it was something to consider. I believe that in the future, many NeoForge mod developers will follow this change, and the original code logic of the launcher may not be applicable.
@Glavo Glavo added this to the Release 3.5.8 milestone Apr 19, 2024
burningtnt added a commit to burningtnt/HMCL that referenced this issue May 5, 2024
@burningtnt
Support HMCL-dev#3000
331d81e
@burningtnt burningtnt mentioned this issue May 5, 2024
Merged
@burningtnt
Copy link
Member

burningtnt commented May 6, 2024 •
edited

Thanks for your reminding. I have changed some codes to adapt to it.

Glavo pushed a commit that referenced this issue May 15, 2024
@burningtnt
Support #3000: Support neoforge.mods.toml (#3031)
af37194 
* Support #3000

* Fix #2371

* Rename references.

* Code cleanup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Release 3.5.8
Development

Successfully merging a pull request may close this issue.

Support #3000: Support neoforge.mods.toml burningtnt/HMCL
3 participants
@Glavo @burningtnt @3gf8jv4dv