Add execute_sql_rds.sh script to run SQL using RDS Data API
#1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouinar
reviewed
Apr 26, 2024
api/bin/execute_sql_rds.sh
Outdated
Comment on lines
20
to
21
| RESOURCE_ARN='arn:aws:rds:...' | ||
| SECRET_ARN='arn:aws:secretsmanager:...' |
There was a problem hiding this comment.
I'm not sure if it would be an issue, but what about making these env vars (or params passed in) so someone is less likely to accidentally check in the ARNs?
Also - it would be good to know what user / role access a person has with this - can this only be the root user? Might be a problem we address later with our own login roles and what they have access to use (ie. almost anyone with AWS access can use a read-only role, only admins can write)
coilysiren
approved these changes
May 9, 2024
| GREEN='\033[92m' | ||
| END='\033[0m' | ||
|
|
||
| CLUSTER=api-dev |
There was a problem hiding this comment.
Suggested change
| CLUSTER=api-dev | |
| # Defaults the --cluster argument to api-dev | |
| CLUSTER=api-dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #{ISSUE}
Time to review: x mins
Changes proposed
execute_sql_rds.shscript to run SQL using RDS Data APIContext for reviewers
During development, this can make it easier to run queries against the dev database.
Additional information