New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPS-1964/task-2128 investigate change requests design #2135
Closed
stevtek
wants to merge
32
commits into
main
from
OPS-1964/task-2128-investigate-change-requests-design
Closed
OPS-1964/task-2128 investigate change requests design #2135
stevtek
wants to merge
32
commits into
main
from
OPS-1964/task-2128-investigate-change-requests-design
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed changes and also BLI getting committed with update_data)
and some investigation of non-financial changes
…re and aren't now (200 vs 202 etc)
…ange-requests-design
more WIP on change request including * stopping status change back to DRAFT and other status changes in PATCH * no longer use update/diff/refresh for changes * new method to built change_data dict that retains dates and enums and typed data instead of string
…ange-requests-design
…ange-requests-design
endpoint for list (query by BLI/agreement not working yet) including change requests in BLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Described what changes in this PR, at a high level
Issue
Add link to issue here
How to test
Write out steps for how someone could test this PR against the acceptance criteria
Screenshots
If relevant, e.g. for a front-end feature
Definition of Done Checklist
Links
If relevant, e.g. for a link to a piece of markdown documentation