Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-2885] Monitoring Findings #2124

Merged
merged 42 commits into from May 13, 2024
Merged

Conversation

GarrettEHill
Copy link
Collaborator

@GarrettEHill GarrettEHill commented Apr 30, 2024

Description of change

  • Update ETL import maintenance job for monitoring data to include pulling in data for findings.
  • Add new tables and models to support the new data
  • Update seed data to account for some of the new structure

How to test

  1. Run ./bin/load-test-db
  2. Enter the docker container running the backend
  3. Run yarn import:system download 1
  4. Run yarn import:system process 1
  5. Verify no errors were thrown
  6. Verify data is present in the table "MonitoringStandards"

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@kryswisnaskas
Copy link
Collaborator

Can tests for the new data also be added in this PR? 🌮

@GarrettEHill
Copy link
Collaborator Author

Can tests for the new data also be added in this PR? 🌮
The new data captured is already covered by the current tests.

Copy link
Collaborator

@AdamAdHocTeam AdamAdHocTeam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a dumb question, but it seems like we are adding alot (10) of models/tables for this new monitoring data. Is there any way we can reduce the number of newly created items?

Maybe some sort of generic data warehouse?

@GarrettEHill
Copy link
Collaborator Author

GarrettEHill commented May 3, 2024

Maybe some sort of generic data warehouse?

No, we need to keep in sync with the data coming in to be able to maintain it correctly.
Think of this more as replication.

Any other structure would require:

  • re-engineering the etl process system in place (Import System)
  • reduce the ability to track changes over time (Audit Log)
  • decrease the efficiency of data access for use on the front end (UI response time)

@GarrettEHill GarrettEHill requested review from kryswisnaskas and removed request for kryswisnaskas May 3, 2024 17:03
Copy link
Collaborator

@hardwarehuman hardwarehuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the code suggestions; I didn't realize how repetitive they would become. You can accept them all or do a global find/replace.

src/models/tests/monitoring/monitoring.test.js Outdated Show resolved Hide resolved
src/models/tests/monitoring/monitoring.test.js Outdated Show resolved Hide resolved
src/models/tests/monitoring/monitoring.test.js Outdated Show resolved Hide resolved
src/models/tests/monitoring/monitoring.test.js Outdated Show resolved Hide resolved
src/models/tests/monitoring/monitoring.test.js Outdated Show resolved Hide resolved
src/models/tests/monitoring/monitoring.test.js Outdated Show resolved Hide resolved
src/models/tests/monitoring/monitoring.test.js Outdated Show resolved Hide resolved
src/models/tests/monitoring/monitoring.test.js Outdated Show resolved Hide resolved
src/models/tests/monitoring/monitoring.test.js Outdated Show resolved Hide resolved
src/models/hooks/genericLink.js Show resolved Hide resolved
GarrettEHill and others added 11 commits May 9, 2024 14:59
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
@GarrettEHill GarrettEHill merged commit eeb4639 into main May 13, 2024
10 checks passed
@GarrettEHill GarrettEHill deleted the TTAHUB-2885/monitoring-findings branch May 13, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants