New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TTAHUB-2885] Monitoring Findings #2124
Conversation
Can tests for the new data also be added in this PR? 🌮 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a dumb question, but it seems like we are adding alot (10) of models/tables for this new monitoring data. Is there any way we can reduce the number of newly created items?
Maybe some sort of generic data warehouse?
No, we need to keep in sync with the data coming in to be able to maintain it correctly. Any other structure would require:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the code suggestions; I didn't realize how repetitive they would become. You can accept them all or do a global find/replace.
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
Co-authored-by: Nato <github@klasser.net>
Description of change
How to test
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy