Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-1230] Show correct options when creator is approver on draft #2122

Merged
merged 4 commits into from May 3, 2024

Conversation

AdamAdHocTeam
Copy link
Collaborator

@AdamAdHocTeam AdamAdHocTeam commented Apr 30, 2024

Description of change

This fixes a bug when a creator or collaborator would visit a report still in draft state with approving managers set. The code would assume that even though the report was in draft (not submitted) and you are an approver to show the approving manager review section. This should not be the case until the report has been set to submitted state.

How to test

  1. Review the code (make sure there are no glaring test cases missing).
  2. Test viewing the report in three states as three types of users Creator, Collaborator, Approver:
  • Draft
  • Submitted
  • Needs Action

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@AdamAdHocTeam AdamAdHocTeam changed the title [TTAHUB-1203] Show correct options when creator is approver on draft [TTAHUB-1230] Show correct options when creator is approver on draft Apr 30, 2024
@thewatermethod
Copy link
Collaborator

thewatermethod commented May 1, 2024

Scenario: I am both creator and approver. I could be wrong about this, so let me know, but after you set a report to "needs action" you should see a resubmit button here.

Screenshot 2024-05-01 at 1 04 04 PM

Nevermind: this matches what we currently have, so I don't know that we need to get any deeper into this

@AdamAdHocTeam AdamAdHocTeam merged commit 31dce83 into main May 3, 2024
10 checks passed
@AdamAdHocTeam AdamAdHocTeam deleted the al-ttahub-1230-correct-options branch May 3, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants