New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TTAHUB-1828] Change all "GROUP BY TRUE" to "GROUP BY 1=1" to support postgres 15.x #1723
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kcirtapfromspace can you look at this |
@GarrettEHill How do you feel about this comment in that thread?
I guess the conversation in there leans towards not maintaining support for group by true this going forward. I'm curious if 1=1 is an obscure format that isn't really covered in the documentation. What alternatives might be used? |
@GarrettEHill did you say yesterday Angela had found an issue with testing this? |
The issue was not with this, but a bug on resource dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, and on dev. Runs on CI.
Description of change
Postgres 15 does not like "GROUP BY TRUE"
https://postgrespro.com/list/thread-id/2661353
work around is to use 1=1 in place of true
Include change to move postgres from 12.4 to 15.4
How to test
tests work, can create a report
Issue(s)
Checklists
Every PR
Production Deploy
After merge/deploy