an alternative approach to the cleanup migration #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+15
to
+22
| SELECT | ||
| "firstName", | ||
| "lastName", | ||
| "role", | ||
| "grantId", | ||
| "programId", | ||
| active, | ||
| MIN(id) AS first_insert |
There was a problem hiding this comment.
This is not the best set of fields to match on, I saw some records that only changed email address, while name remained the same. and others where the name changed and email remained the same. I think email needs to be included for comparison.
| ) | ||
| DELETE FROM "ProgramPersonnel" | ||
| WHERE id NOT IN (SELECT first_insert FROM initial_entries); |
There was a problem hiding this comment.
Why are you using the "in select" syntax vs the using syntax
|
|
||
| /* 2. Make a copy of the audit log before cleaning it up */ | ||
| SET session_replication_role = replica; | ||
| CREATE TABLE "ZZarchiveZALProgramPersonnel20230828103020" AS SELECT * FROM "ZALProgramPersonnel"; |
There was a problem hiding this comment.
This is a real table and have an audit log generated for it. I don't think that is what is intended.
| WHERE id NOT IN (SELECT first_insert FROM initial_entries); | ||
|
|
||
| /* 2. Make a copy of the audit log before cleaning it up */ | ||
| SET session_replication_role = replica; |
There was a problem hiding this comment.
This is not how to turn off audit log
| /* 3. Delete everything we don't want to keep */ | ||
| DELETE FROM "ProgramPersonnel" WHERE id NOT IN (SELECT "idToKeep" FROM "ProgramPersonnelToKeep"); | ||
| /* 3. Clean out the huge number of records related to deleted dupes */ | ||
| DELETE FROM "ZALProgramPersonnel" WHERE data_id NOT IN (SELECT id FROM "ProgramPersonnel"); |
There was a problem hiding this comment.
Why are you using the "in select" syntax vs the using syntax
Base automatically changed from
al-ttahub-2043-program-personnel-fixes
to
main
September 1, 2023 16:38
|
Should we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This illustrates some changes. They work, but there's other issues we need to discuss and investigate before we call it done.