[TTAHUB-1896] Rework worker and resource processer for increased stability and complete processing #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarrettEHill
changed the title
11 tasks
| const onCompletedAWSElasticsearchQueue = (job, result) => { | ||
| const onFailedAWSElasticsearchQueue = async (job, error) => { | ||
| auditLogger.error(`job ${job.data.key} failed with error ${error}`); | ||
| await job.retry(); |
There was a problem hiding this comment.
Not sure we should be manually triggering retries. This should be handled automatically by the bull framework when an exception is thrown.
There was a problem hiding this comment.
I see this in a few places below.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add awaits to the processing of queues
How to test
Issue(s)
Checklists
Every PR
Production Deploy
After merge/deploy