Resending email invitations implementation #516
Conversation
zeynepaki
commented
May 24, 2022
zeynepaki
commented
- Fixes dashboard: add option to manager widget to resend email invitations to Uploaders/Reviewers #191
There was a problem hiding this comment.
Thanks, this looks great! I've tested and it works well, but I think some small changes are needed in the new send_reminder_email function (commented separately). Also, it wasn't mentioned in the original issue #191, but I made some comments elsewhere (linked from #191) that I'd like an option for the Coordinator to add a personalised message to the reminder. Sorry that I didn't make that clear. Could you please add a text box (similar to the one available from the "Notify Participants" button) where the Coordinator could add an optional message to be passed to submission_status.html?
| ) | ||
| coordinator = User.query.get(hepsubmission.coordinator) | ||
|
|
||
| reviewers_notified = submission_participant.user_account is not None |
There was a problem hiding this comment.
Not sure about this. I would just set reviewers_notified = True to get the correct text in submission_status.html.
| actor=coordinator.email, | ||
| article=record_information['recid'], | ||
| message=None, | ||
| invite_token=submission_participant.invitation_cookie, |
There was a problem hiding this comment.
The invite_token should be set as in send_notification_email, i.e.
invite_token = None
if not submission_participant.user_account:
invite_token = submission_participant.invitation_cookieThis ensures that the link to assign permissions is not displayed in submission_status.html if the permissions have already been claimed.
| if not reviewers_notified: | ||
| message_subject = '[HEPData] Reminder to review submission {0}'.format(record_information['recid']) | ||
| else: | ||
| message_subject = '[HEPData] Reminder about submission {0}'.format(record_information['recid']) |
There was a problem hiding this comment.
Instead of using reviewers_notified in these conditions I would check for if submission_participant.role == 'reviewer' to use the first subject, else use the second subject.
