Collapsed and Expand events based on elemental2.dom.MutationObserver #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-eggert
commented
Apr 26, 2018
d-eggert
commented
- added elemental2.dom.Dom dependency
- disabled non working tests
- addresses MaterialCollapsible - additional events for Collapse / Expand. #780
- added elemental2.dom.Dom dependency - disabled non working tests
vegegoku
reviewed
Apr 26, 2018
| */ | ||
| private Object onMutation(MutationRecord[] records) { | ||
| for (MutationRecord r : records) { | ||
| System.out.println(r.target.nodeName + " " + r.attributeName + ": " + r.oldValue + " type: " + r.type); |
There was a problem hiding this comment.
Maybe this should be removed 😄
There was a problem hiding this comment.
Yup agreed we must remove any debug logs.
|
Does one of you have an idea for fixing the test case? |
|
Might need to check this tomorrow, as I am on Addins for today for fixing the bugs. |
|
This pull request should be merge later on 2.2 branch. I will create a branch for it later. Because elemental2 shouldnt be included in 2.1 - as we might have an internal changes like dom.elements etc. |
|
We plan to migrate our GMD widget to elemental on 2.6.0 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.