Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed NullPointerException in GXDLMS.getDescription #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed NullPointerException in GXDLMS.getDescription #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7e222b
fix NullPointerException
Jul 13, 2016
9ca8498
improve default error message
Jul 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
121 changes: 63 additions & 58 deletions development/src/main/java/gurux/dlms/GXDLMS.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,65 +266,70 @@ static byte[] receiverReady(final GXDLMSSettings settings,

static String getDescription(final int errCode) {
String str;
switch (ErrorCode.forValue(errCode)) {
case REJECTED:
str = "Rejected";
break;
case INVALID_HDLC_REPLY:
str = "Not a reply";
break;
case OK:
str = "";
break;
case HARDWARE_FAULT:
str = "Access Error : Device reports a hardware fault.";
break;
case TEMPORARY_FAILURE:
str = "Access Error : Device reports a temporary failure.";
break;
case READ_WRITE_DENIED:
str = "Access Error : Device reports Read-Write denied.";
break;
case UNDEFINED_OBJECT:
str = "Access Error : Device reports a undefined object.";
break;
case INCONSISTENT_CLASS:
str = "Access Error : "
+ "Device reports a inconsistent Class or object.";
break;
case UNAVAILABLE_OBJECT:
str = "Access Error : Device reports a unavailable object.";
break;
case UNMATCHED_TYPE:
str = "Access Error : Device reports a unmatched type.";
break;
case ACCESS_VIOLATED:
str = "Access Error : Device reports scope of access violated.";
break;
case DATA_BLOCK_UNAVAILABLE:
str = "Access Error : Data Block Unavailable.";
break;
case LONG_GET_OR_READ_ABORTED:
str = "Access Error : Long Get Or Read Aborted.";
break;
case NO_LONG_GET_OR_READ_IN_PROGRESS:
str = "Access Error : No Long Get Or Read In Progress.";
break;
case LONG_SET_OR_WRITE_ABORTED:
str = "Access Error : Long Set Or Write Aborted.";
break;
case NO_LONG_SET_OR_WRITE_IN_PROGRESS:
str = "Access Error : No Long Set Or Write In Progress.";
break;
case DATA_BLOCK_NUMBER_INVALID:
str = "Access Error : Data Block Number Invalid.";
break;
case OTHER_REASON:
str = "Access Error : Other Reason.";
break;
default:
ErrorCode errorCode = ErrorCode.forValue(errCode);
if (errorCode != null) {
switch (errorCode) {
case REJECTED:
str = "Rejected";
break;
case INVALID_HDLC_REPLY:
str = "Not a reply";
break;
case OK:
str = "";
break;
case HARDWARE_FAULT:
str = "Access Error : Device reports a hardware fault.";
break;
case TEMPORARY_FAILURE:
str = "Access Error : Device reports a temporary failure.";
break;
case READ_WRITE_DENIED:
str = "Access Error : Device reports Read-Write denied.";
break;
case UNDEFINED_OBJECT:
str = "Access Error : Device reports a undefined object.";
break;
case INCONSISTENT_CLASS:
str = "Access Error : "
+ "Device reports a inconsistent Class or object.";
break;
case UNAVAILABLE_OBJECT:
str = "Access Error : Device reports a unavailable object.";
break;
case UNMATCHED_TYPE:
str = "Access Error : Device reports a unmatched type.";
break;
case ACCESS_VIOLATED:
str = "Access Error : Device reports scope of access violated.";
break;
case DATA_BLOCK_UNAVAILABLE:
str = "Access Error : Data Block Unavailable.";
break;
case LONG_GET_OR_READ_ABORTED:
str = "Access Error : Long Get Or Read Aborted.";
break;
case NO_LONG_GET_OR_READ_IN_PROGRESS:
str = "Access Error : No Long Get Or Read In Progress.";
break;
case LONG_SET_OR_WRITE_ABORTED:
str = "Access Error : Long Set Or Write Aborted.";
break;
case NO_LONG_SET_OR_WRITE_IN_PROGRESS:
str = "Access Error : No Long Set Or Write In Progress.";
break;
case DATA_BLOCK_NUMBER_INVALID:
str = "Access Error : Data Block Number Invalid.";
break;
case OTHER_REASON:
str = "Access Error : Other Reason.";
break;
default:
str = "Access Error : Unknown error.";
break;
}
} else {
str = "Access Error : Unknown error.";
break;
}
return str;
}
Expand Down