Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent denial of service in GXCommon.getCompactArray #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bbobcik
Copy link

@bbobcik bbobcik commented Sep 26, 2023

If a malfunctioning/rogue device indicated zero columns for a compact array, the code entered an infinite loop, allocating empty ArrayLists until heap memory got exhausted. This could lead to denial-of-service attacks, as the caller has no means for recovery attempt.

This change defensively detects such abnormal situation and handles it by returning a simple list of empty lists.

In addition, formerly overloaded variable len is disambiguated into colCount and rowCount in order to improve clarity of the code.

If a malfunctioning/rogue device indicated zero columns for a compact array, the code entered an infinite loop, allocating empty ArrayLists until heap memory got exhausted. This could lead to denial-of-service attacks, as the caller has no means for recovery attempt.
This change defensively detects such abnormal situation and handles it by returning a simple list of empty lists.
In addition, formerly overloaded variable len is disambiguated into colCount and rowCount in order to improve clarity of the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant