Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.8.2 -- Fixed Tests #811

Open
wants to merge 8 commits into
base: release-0.8.2
Choose a base branch
from

Conversation

thathenderson
Copy link

Note: went ahead and made the react/react-dom 0.14.x and 15.4.x devDependencies changes discussed briefly in #809. I can easily revert that if anyone is uncomfortable with the idea, but then a discussion needs to be had around how to fix react-addons-test-utils issues.

Griddle major version

0.8.2 (fixes targeted for this version release)

Changes proposed in this pull request

  • Deprecating React 0.14.x and 15.4.x support in devDependencies
  • Fixing React Test Utils package dependency, along with related dependencies (ShallowRenderer)
  • Fixing es2015 Map constructor errors with a babel polyfill

Why these changes are made

To get passing tests!

Are there tests?

No new tests; all existing tests pass (as of this branch)

Michael Henderson added 8 commits April 17, 2018 14:48
…s2015 Map constructor warnings; Adding react-test-renderer
…er/shallow package; Replacing all references to react-addons-test-utils with react-dom/test-utils
…st-utils; Commenting out an unnecessary console.log
…mping up the minimum supported versions to 15.5.4
…n devDependencies to a version that supports react 16.x, and bumping react-test-renderer 16.x support back down to ^16.0.0
@thathenderson
Copy link
Author

Tried a few things, but it seems like I can't update react-chartist to solve peer dependency errors in Node 4 and below due to some issues between the webpack:docs task and react-chartist 0.13.1.

Not sure how to proceed with that, but at least it seems to work fine in Node 5+

@dahlbyk
Copy link
Contributor

dahlbyk commented May 4, 2018

FWIW, @ryanlanciaux @joellanciaux the Chartist demo on https://griddlegriddle.github.io/v0-docs/customization.html is broken:

TypeError: root is undefined (ChartistGraph.js:177:108)
Warning: Each child in an array or iterator should have a unique "key" prop. Check the render method of OtherPager. See https://fb.me/react-warning-keys for more information. (react.js:19254:9)
TypeError: Chartist[type] is not a constructor (ChartistGraph.js:129:26)

@ryanlanciaux
Copy link
Member

Ahh - wonder if we should take that out.

@dahlbyk
Copy link
Contributor

dahlbyk commented May 4, 2018

Ahh - wonder if we should take that out.

Nobody seems to have noticed, so it doesn't seem worth bending over backward to manage the extra dependency just for docs. 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants