Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(src): subtract plugin #90

Merged
merged 2 commits into from May 20, 2024
Merged

feat(src): subtract plugin #90

merged 2 commits into from May 20, 2024

Conversation

pazbardanl
Copy link
Contributor

@pazbardanl pazbardanl commented May 6, 2024 •
edited

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • New generic plugin for subtract operator

@pazbardanl pazbardanl marked this pull request as ready for review May 6, 2024 20:56
manushak
manushak reviewed May 7, 2024
View reviewed changes
src/lib/subtract/index.ts Outdated Show resolved Hide resolved
src/lib/subtract/index.ts Outdated Show resolved Hide resolved
src/lib/subtract/index.ts Outdated Show resolved Hide resolved
src/lib/subtract/README.md Outdated Show resolved Hide resolved
manushak
manushak reviewed May 14, 2024
View reviewed changes
src/lib/subtract/index.ts Outdated Show resolved Hide resolved
src/lib/subtract/README.md Outdated Show resolved Hide resolved
src/lib/subtract/README.md Outdated Show resolved Hide resolved
src/lib/subtract/index.ts Outdated Show resolved Hide resolved
manushak
manushak reviewed May 14, 2024
View reviewed changes
src/lib/subtract/index.ts Outdated Show resolved Hide resolved
@pazbardanl
feat(src): substract plugin
81ce934 
Signed-off-by: Paz Barda <paz.barda@intel.com>
@pazbardanl
Copy link
Contributor Author

@manushak @jmcook1186 @narekhovhannisyan I think all comments have been reviewed and fixed accordingly, please review. thanks :)

@jmcook1186 jmcook1186 mentioned this pull request May 16, 2024
Open
@jmcook1186 jmcook1186 added the awaiting-qa PR is waiting for QA approval label May 16, 2024
@jmcook1186 jmcook1186 linked an issue May 20, 2024 that may be closed by this pull request
Design a generic subtract plugin Green-Software-Foundation/if#672
Closed
10 tasks
jmcook1186
jmcook1186 approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm!

@jmcook1186 jmcook1186 changed the title feat(src): substract plugin feat(src): subtract plugin May 20, 2024
@jmcook1186 jmcook1186 merged commit 0236f41 into main May 20, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the generic-substract branch May 20, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manushak manushak manushak approved these changes

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@narekhovhannisyan narekhovhannisyan Awaiting requested review from narekhovhannisyan

Assignees

@MariamKhalatova MariamKhalatova

Labels
awaiting-qa PR is waiting for QA approval
Projects
IF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design a generic subtract plugin
4 participants
@pazbardanl @manushak @jmcook1186 @MariamKhalatova