-
-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mirror node #1632
Add Mirror node #1632
Conversation
Your code looks nice! However I need to get @TrueDoctor's comment about the addition of the |
Blocked on #1558. We'll have to let this wait a bit. Hopefully @TrueDoctor can complete that issue in the next week or two. Because it'll require a little bit of rework once that is merged (sorry for the trouble!), and because I want to make sure I can know which PRs require my attention, I'm going to mark this as a draft PR for now to help me stay organized. Apologies for the delay and extra effort this blockage, which isn't your fault, will incur. |
7bf7f92
to
5f4960d
Compare
I think I'll close this for now. Thanks for your efforts, and I'm sure you learned a lot from this that'll be helpful knowledge as you work on the animation project this summer. But with the awkwardness of how transforms are currently (not) dealt with, it's rather hard to approach this at the moment. And there are lots of merge conflicts so closing for the moment is the easiest way to proceed. Thanks though! |
This will add the Mirror node:
This will close #1453 when finished.