Test modification of a task by an on-add hook (test case for #3416) #3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, the simplest fix is reordering the on-add hook invocation before the save. That fixes the issue while passing the test suite. However, I don't know if it is the behaviour that you want. Anything more complicated is beyond my affinity with C++. |
|
On a related note, 3e14d92 is a copy of https://github.com/GothenburgBitFactory/taskwarrior/blob/develop/scripts/hooks/on-add.the with some added comments. |
djmitche
approved these changes
May 15, 2024
djmitche
added a commit
to djmitche/taskwarrior
that referenced
this pull request
May 15, 2024
This test existed, but didn't notice that the task was actually added. The bug itself was fixed in GothenburgBitFactory#3443.
djmitche
added a commit
that referenced
this pull request
May 15, 2024
This test existed, but didn't notice that the task was actually added. The bug itself was fixed in #3443.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test case that shows the bug described in #3416. I confirmed it fails on current develop.
I think the bug's root cause is 5bb9857#r141727451.
For a fix:
TBD2::update()as a method was removed in the referenced commit. And it seems callingTBD2::modify()instead will fire on-modify hooks when saving changes by on-add to the database. That's about as far as I got, I hope this contribution will help someone else make progress.