Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the documentation to make selection of elements clear. #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zoramite
Copy link
Contributor

Also provides guidance on how to use the google-signin-aware with custom signin UIs.

Closes #143

…in` works.

Also provides guidance on how to use the `google-signin-aware` with custom signin UIs.

Closes #143

#### Notes
#### Notes
Copy link
Contributor

@ebidel ebidel Jun 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the indentation? For the doc viewer, this is read as markdown, so 4-space indents will make this a code block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't it use the spacing of the opening comment as the base for all of the lines?
If that is not true then I'll have to change it back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably easier if we just make the docs a html comment like https://github.com/GoogleWebComponents/google-sheets/blob/master/google-sheets.html#L7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants