Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply max line length to 80 #178

Merged
merged 3 commits into from Mar 5, 2024
Merged

Conversation

RissyRan
Copy link
Collaborator

@RissyRan RissyRan commented Mar 4, 2024

Description

We added Pylint in this PR, and now apply max line length to 80 to match Google Style (we will have an internal repo for NPI work), with:

  • Name changes, i.e. change check name from build to linting_check
  • Upgrade python version to 3.10 for formatter check (match existing composer env)

Tests

Please describe the tests that you ran on Cloud VM to verify changes.

Instruction and/or command lines to reproduce your tests: ...
Upload dags to airflow, and have an simple run

List links for your tests (use go/shortn-gen for any internal link): ...
A few sanity tests:

  • Flax test on v3-8 - GCE: link
  • xpk exmaple dag - GKE: link
  • Jax test - Jsonnet: link

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

Copy link
Collaborator

@jonb377 jonb377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Ran!

.github/workflows/pre-commit.yml Show resolved Hide resolved
@RissyRan RissyRan assigned gkroiz and unassigned will-cromar and chandrasekhard2 Mar 5, 2024
@RissyRan RissyRan merged commit f97cdd1 into GoogleCloudPlatform:master Mar 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants