Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

privateca/snippets test(s) are failing #8966 #9320

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

privateca/snippets test(s) are failing #8966 #9320

wants to merge 7 commits into from
+5 −7

Conversation

ssvir
Copy link
Collaborator

@ssvir ssvir commented May 10, 2024

Description

unignore tests rerun 6 times without failings
Fixes #8966

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@ssvir ssvir requested a review from Sita04 May 10, 2024 09:39
@ssvir ssvir requested review from yoshi-approver and a team as code owners May 10, 2024 09:39
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: privateca Issues related to the Certificate Authority Service API. labels May 10, 2024
@ssvir ssvir added kokoro:run Add this label to force Kokoro to re-run the tests. and removed samples Issues that are directly related to samples. api: privateca Issues related to the Certificate Authority Service API. labels May 10, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 10, 2024
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 11, 2024
@ssvir ssvir added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@ssvir ssvir added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:rebuild and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels May 14, 2024
@ssvir ssvir added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@ssvir ssvir added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@ssvir ssvir added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@ssvir ssvir added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@ssvir ssvir added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2024
Sita04
Sita04 requested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@Sita04 Sita04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssvir Kindly address the failing tests.

privateca/snippets/src/test/java/privateca/SnippetsIT.java
Comment on lines +112 to +113
// Util.cleanUpCaPool(PROJECT_ID, LOCATION);
// TimeUnit.SECONDS.sleep(30);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly uncomment this. I believe this deletes any stale CA pools leftover from previous tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sita04 Sita04 Sita04 requested changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@Sita04 Sita04

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

privateca/snippets test(s) are failing
3 participants
@ssvir @Sita04 @kokoro-team