Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved files from "update IAM policy samples to use GAPIC library" PR #9319

Merged
merged 7 commits into from May 16, 2024

Conversation

ssvir
Copy link
Collaborator

@ssvir ssvir commented May 9, 2024

Description

moved files from "update IAM policy samples to use GAPIC library" PR to snippets module

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@ssvir ssvir requested a review from Sita04 May 9, 2024 19:56
@ssvir ssvir requested review from yoshi-approver and a team as code owners May 9, 2024 19:56
@ssvir ssvir added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 9, 2024
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: iam Issues related to the Identity and Access Management API. labels May 9, 2024
Copy link

snippet-bot bot commented May 9, 2024

Here is the summary of changes.

You are about to add 8 region tags.
You are about to delete 8 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 9, 2024
@ssvir ssvir added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@ssvir ssvir added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@ssvir ssvir added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@Sita04 Sita04 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 15, 2024
@Sita04 Sita04 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 16, 2024
@Sita04 Sita04 merged commit a78aae9 into main May 16, 2024
12 checks passed
@Sita04 Sita04 deleted the move-iam-policy-java branch May 16, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: iam Issues related to the Identity and Access Management API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants