New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(iam): update service account samples to use GAPIC library #9293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO this should be moved out from iam/api-client to iam/cloud-client. @Sita04 please advise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the snippets!
PTAL at the review comments.
iam/api-client/src/main/java/iam/snippets/CreateServiceAccountKey.java
Outdated
Show resolved
Hide resolved
iam/api-client/src/main/java/iam/snippets/CreateServiceAccountKey.java
Outdated
Show resolved
Hide resolved
iam/api-client/src/main/java/iam/snippets/CreateServiceAccountKey.java
Outdated
Show resolved
Hide resolved
iam/api-client/src/main/java/iam/snippets/CreateServiceAccountKey.java
Outdated
Show resolved
Hide resolved
iam/api-client/src/main/java/iam/snippets/CreateServiceAccountKey.java
Outdated
Show resolved
Hide resolved
iam/api-client/src/main/java/iam/snippets/CreateServiceAccountKey.java
Outdated
Show resolved
Hide resolved
iam/api-client/src/main/java/iam/snippets/ListServiceAccountKeys.java
Outdated
Show resolved
Hide resolved
iam/api-client/src/main/java/iam/snippets/ListServiceAccounts.java
Outdated
Show resolved
Hide resolved
iam/api-client/src/test/java/iam/snippets/ServiceAccountTests.java
Outdated
Show resolved
Hide resolved
Agreed it should be moved out of api-client folder. We have an existing folder for GAPIC samples under @hegemonic for visibility. |
Should only the updated snippets or the entire iam/api-client be moved to the new folder? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments.
iam/api-client/src/main/java/iam/snippets/CreateServiceAccountKey.java
Outdated
Show resolved
Hide resolved
iam/api-client/src/main/java/iam/snippets/CreateServiceAccountKey.java
Outdated
Show resolved
Hide resolved
iam/api-client/src/main/java/iam/snippets/CreateServiceAccountKey.java
Outdated
Show resolved
Hide resolved
iam/api-client/src/main/java/iam/snippets/CreateServiceAccountKey.java
Outdated
Show resolved
Hide resolved
iam/api-client/src/main/java/iam/snippets/GetServiceAccountKey.java
Outdated
Show resolved
Hide resolved
iam/api-client/src/main/java/iam/snippets/ListServiceAccountKeys.java
Outdated
Show resolved
Hide resolved
iam/api-client/src/main/java/iam/snippets/ListServiceAccounts.java
Outdated
Show resolved
Hide resolved
iam/api-client/src/main/java/iam/snippets/GetServiceAccount.java
Outdated
Show resolved
Hide resolved
Only the snippets that are updated should be moved to the |
# Conflicts: # iam/api-client/pom.xml # iam/api-client/src/test/java/iam/snippets/ServiceAccountTests.java
@msilc Kindly fix the failed tests. |
This reverts commit 336fa98.
Description
Service accounts snippets rewrote using a new library
Checklist
pom.xml
parent set to latestshared-configuration
mvn clean verify
requiredmvn -P lint checkstyle:check
requiredmvn -P lint clean compile pmd:cpd-check spotbugs:check
advisory only