Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iam): update service account samples to use GAPIC library #9293

Merged
merged 23 commits into from May 13, 2024

Conversation

msilc
Copy link
Collaborator

@msilc msilc commented Apr 17, 2024

Description

Service accounts snippets rewrote using a new library

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@msilc msilc requested a review from Sita04 April 17, 2024 12:04
@msilc msilc requested review from yoshi-approver and a team as code owners April 17, 2024 12:04
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: iam Issues related to the Identity and Access Management API. labels Apr 17, 2024
Copy link
Member

@rsamborski rsamborski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this should be moved out from iam/api-client to iam/cloud-client. @Sita04 please advise.

@rsamborski rsamborski assigned Sita04 and unassigned bourgeoisor Apr 17, 2024
@kweinmeister kweinmeister added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 17, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 17, 2024
Copy link
Contributor

@Sita04 Sita04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the snippets!
PTAL at the review comments.

@Sita04
Copy link
Contributor

Sita04 commented Apr 17, 2024

IMHO this should be moved out from iam/api-client to iam/cloud-client. @Sita04 please advise.

Agreed it should be moved out of api-client folder. We have an existing folder for GAPIC samples under iam/snippets
Kindly consider creating a new sub-folder and moving these.
We should also make note to update doc references for the samples.

@hegemonic for visibility.

@Sita04 Sita04 changed the title Service accounts snippets rewrote using a new library refactor(iam): update service account samples to use GAPIC library Apr 18, 2024
@msilc msilc requested a review from Sita04 April 24, 2024 19:35
@msilc
Copy link
Collaborator Author

msilc commented Apr 24, 2024

IMHO this should be moved out from iam/api-client to iam/cloud-client. @Sita04 please advise.

Agreed it should be moved out of api-client folder. We have an existing folder for GAPIC samples under iam/snippets Kindly consider creating a new sub-folder and moving these. We should also make note to update doc references for the samples.

@hegemonic for visibility.

Should only the updated snippets or the entire iam/api-client be moved to the new folder?

Copy link
Contributor

@Sita04 Sita04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments.

@Sita04
Copy link
Contributor

Sita04 commented Apr 26, 2024

IMHO this should be moved out from iam/api-client to iam/cloud-client. @Sita04 please advise.

Agreed it should be moved out of api-client folder. We have an existing folder for GAPIC samples under iam/snippets Kindly consider creating a new sub-folder and moving these. We should also make note to update doc references for the samples.
@hegemonic for visibility.

Should only the updated snippets or the entire iam/api-client be moved to the new folder?

Only the snippets that are updated should be moved to the iam/snippets folder. Thanks!

Copy link

snippet-bot bot commented Apr 30, 2024

Here is the summary of changes.

You are about to add 11 region tags.
You are about to delete 11 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@Sita04
Copy link
Contributor

Sita04 commented May 6, 2024

@msilc Kindly fix the failed tests.

@msilc msilc added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels May 7, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2024
@msilc msilc added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2024
@msilc msilc added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 9, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 9, 2024
@msilc msilc added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 9, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 9, 2024
@msilc msilc added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 9, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 9, 2024
@msilc msilc added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 9, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 9, 2024
@msilc msilc added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 9, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 9, 2024
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2024
@Sita04 Sita04 merged commit 88da97f into main May 13, 2024
11 checks passed
@Sita04 Sita04 deleted the iam_service_accounts_java branch May 13, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: iam Issues related to the Identity and Access Management API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants