Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of duplicated snippets "talent/snippets" #9287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

msilc
Copy link
Collaborator

@msilc msilc commented Apr 16, 2024

Description

Removal of duplicated snippets "talent/snippets"

Fixes #7872

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@msilc msilc requested review from yoshi-approver and a team as code owners April 16, 2024 08:04
Copy link

google-cla bot commented Apr 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

snippet-bot bot commented Apr 16, 2024

Here is the summary of changes.

You are about to delete 18 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: jobs Issues related to the Cloud Talent Solution Job Search API. labels Apr 16, 2024
@msilc msilc requested a review from Sita04 April 16, 2024 21:24
@Sita04
Copy link
Contributor

Sita04 commented Apr 18, 2024

@GoogleCloudPlatform/dee-data-ai needs to verify that all samples can be safely deleted.

@Sita04 Sita04 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: jobs Issues related to the Cloud Talent Solution Job Search API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate samples: jobs/v4 and talent/snippets
2 participants