Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: migrating Bigtable workload generator example to not use Hbase #9235

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

billyjacobson
Copy link
Member

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: bigtable Issues related to the Bigtable API. labels Feb 5, 2024
@kolea2 kolea2 assigned mutianf and igorbernstein2 and unassigned kolea2 Feb 5, 2024
@billyjacobson billyjacobson changed the title docs: migrating example to not use Hbase docs: migrating Bigtable workload generator example to not use Hbase Feb 5, 2024
some cleanup in response to comments
bigtable/beam/workload-generator/README.md Outdated Show resolved Hide resolved
void setup() throws IOException {
synchronized (lock) {
if (++refCount == 1) {
bigtableDataClient = BigtableDataClient.create(this.projectId, this.instanceId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, you might want to add a catch to rollback the refCount if you failed to instantiate the client

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the client fails to initiate won't the whole program exit from the exception? I could add the catch and just print that the connection failed, but for the purposes of this example I feel like it is fine to just fail?

@billyjacobson billyjacobson added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2024
@minherz minherz added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants