Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input type test for additional_networks #2583

Merged
merged 1 commit into from
May 14, 2024

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented May 13, 2024

No description provided.

@mr0re1 mr0re1 added the release-chore To not include into release notes label May 13, 2024
@mr0re1 mr0re1 requested a review from tpdownes May 13, 2024 20:36
@tpdownes
Copy link
Member

tpdownes commented May 14, 2024

I think there is some user experience here that we need to look at it for adoption optional but having this integration test will ensure we do that uniformly in the Toolkit.

There is not yet a way to detect the additional_networks field within the node_groups parameter to the partition module?

Is there a way to treat network_interfaces (vm-instance) as identical in structure?

@tpdownes tpdownes assigned mr0re1 and unassigned tpdownes May 14, 2024
@mr0re1
Copy link
Collaborator Author

mr0re1 commented May 14, 2024

There is not yet a way to detect the additional_networks field within the node_groups parameter to the partition module?

Sure we can do that

Is there a way to treat network_interfaces (vm-instance) as identical in structure?

Sure, we can do that as well

@mr0re1 mr0re1 merged commit 6b3fd39 into GoogleCloudPlatform:develop May 14, 2024
10 of 49 checks passed
@mr0re1 mr0re1 deleted the add_net branch May 14, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants