ci: add tests for latest release of Eclipse #3661
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the only Java 8 build, it's failing due to something no longer supporting Java 8: |
|
Actually, Kokoro Windows is running Java 8, so that's failing with the same error. We can easily upgrade Java there to 11 though. |
|
For the other failures, it's compilation errors: |
chanseokoh
reviewed
Dec 14, 2021
There was a problem hiding this comment.
Thanks for putting this up! This should fix #3659, I suppose?
| <product.version.qualifier.suffix/> <!-- 0-length string by default --> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <eclipse.target>2018-09</eclipse.target> <!-- the default build --> | ||
| <!-- <eclipse.target>latest-release</eclipse.target> --> <!-- the default build --> |
There was a problem hiding this comment.
I guess your intention is to have this as documentation, which is nice. But what usually happens is that someone who sees this later just cleans up these kinds of comments, thinking that they are unnecessary code or mistakenly left.
| <activation> | ||
| <property> | ||
| <name>!eclipse.target</name> | ||
| <!-- when no longer the default: <name>eclipse.target</name> <value>2018-09</value> --> | ||
| <!-- <name>eclipse.target</name> <value>latest-release</value> --> |
|
Oops, I should have marked this as "draft". It compiles on my macbook, but I hadn't actually tried running the real tests. These |
briandealwis
force-pushed
the
eclipse-latest
branch
from
94f7713
to
7568506
Compare
zhumin8
added a commit
that referenced
this pull request
Aug 1, 2022
update readme with info to reflect that Eclipse 4.22 and later are currently not supported. Eclipse latest is currently on 4.24 now and 4.25 will come out soon. Related issues got fired in #3659, #3660, #3678; attempts to fix in #3661 but no progress since. Suggest adding this to readme and removing when this issue actually get fixed.
zhumin8
added a commit
that referenced
this pull request
Aug 1, 2022
update readme with info to reflect that Eclipse 4.22 and later are currently not supported. Eclipse latest is currently on 4.24 now and 4.25 will come out soon. Related issues got fired in #3659, #3660, #3678; attempts to fix in #3661 but no progress since. Adding this to readme. Remove when this issue actually get fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for running tests against the latest release of Eclipse (https://download.eclipse.org/releases/latest).
I had to add
javax.injectto several bundles: I think something must have stopped addingjavax.injectto the system bundle.