test(all): remove all references to CleanBucket #4000
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
the
samples
BrennaEpp
changed the title
internal/testutil/storage_cleaner.go
Outdated
|
|
||
| // UniqueBucketName returns a unique name with the test prefix. | ||
| // UniqueBucketName returns a unique name with the test prefix | ||
| // Any bucket created with this prefix may be deleted by DeleteExpiredBuckets. |
There was a problem hiding this comment.
Is this actually true?
If so we should be sure to leave bucket prefixes alone for existing tests so we don't accidentally try to delete any buckets that people want to save.
There was a problem hiding this comment.
Hmm, so it's true in that it "may" be lol. That is, if you call DeleteExpiredBuckets with the same prefix, which we do in storage tests I believe, those buckets will be deleted. But it's confusing, so I'll delete this comment. We definitely aren't storing prefixes and then deleting buckets based on that.
There was a problem hiding this comment.
Could you double check that you haven't changed prefixes for anything that does use DeleteExpiredBuckets? Otherwise we are good I'd say.
There was a problem hiding this comment.
Check done - nothing to note.
BrennaEpp
added
kokoro:run
kokoro-team
removed
kokoro:run
Description
Fixes #3565
Bumps the version of golang-samples to pick up changes to testutil. Replaces references to
CleanBucketwith methods that include bucket cleanup and error checking.Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
go test -v ./..(see Testing)gofmt(see Formatting)go vet(see Formatting)