Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use Cloud SQL Proxy v2 in READMEs #3998

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

enocom
Copy link
Member

@enocom enocom commented Apr 15, 2024

Also remove references to service account keys in favor of application default credentials.

Related to GoogleCloudPlatform/nodejs-docs-samples#3635

Also remove references to service account keys in favor of application
default credentials.

Related to GoogleCloudPlatform/nodejs-docs-samples#3635
@enocom enocom requested review from a team as code owners April 15, 2024 21:29
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 15, 2024
Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Thanks for proactively updating go readmes in addition to the Node.js ones.

1. Create a service account with the 'Cloud SQL Client' permissions by following these
[instructions](https://cloud.google.com/sql/docs/mysql/connect-external-app#4_if_required_by_your_authentication_method_create_a_service_account).
Download a JSON key to use to authenticate your connection.
1. Set up [Application Default Credentials][adc]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enocom probably still worth highlighting the need of the Cloud SQL Client IAM role?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants