Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datastore): Datastore query profiling samples #3742

Merged
merged 11 commits into from May 21, 2024

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Jan 17, 2024

Description

This PR adds samples for query profiling. This PR will be merged after googleapis/google-cloud-go#9200

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@bhshkh bhshkh requested review from a team as code owners January 17, 2024 10:28
Copy link

snippet-bot bot commented Jan 17, 2024

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 17, 2024
@bhshkh bhshkh changed the title Feature/ds query profiling feat(datastore): Datastore query profiling samples Jan 17, 2024
@bhshkh
Copy link
Contributor Author

bhshkh commented Mar 29, 2024

Do not merge until release freeze ends in mid April

@bhshkh bhshkh added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 29, 2024
Copy link

@danieljbruce danieljbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need runAggregationQuery examples as well?

@bhshkh
Copy link
Contributor Author

bhshkh commented May 12, 2024

Do we need runAggregationQuery examples as well?

Added

@bhshkh bhshkh removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 12, 2024
@bhshkh bhshkh enabled auto-merge (squash) May 12, 2024 19:48
@bhshkh bhshkh requested review from a team and danieljbruce May 14, 2024 23:57
@bhshkh bhshkh merged commit 1d75cfd into GoogleCloudPlatform:main May 21, 2024
9 checks passed
Copy link

@gkevinzheng gkevinzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants