Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vertexai): clean up chat example #3616

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(vertexai): clean up chat example #3616

wants to merge 3 commits into from

Conversation

jba
Copy link
Collaborator

@jba jba commented Dec 13, 2023

Description

Change the chat example to use more idiomatic Go.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • [ x] Please merge this PR for me once it is approved

@jba jba requested a review from a team as a code owner December 13, 2023 21:09
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 13, 2023
@jba jba requested a review from muncus December 13, 2023 21:11
@jba
Copy link
Collaborator Author

jba commented Dec 13, 2023

/cc @eliben

Copy link
Collaborator

@muncus muncus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from the minor fix noted, this looks great. Thanks!

vertexai/chat/chat_test.go Outdated Show resolved Hide resolved
@jba
Copy link
Collaborator Author

jba commented Feb 15, 2024

The CodeQL/Analyze step has the error

 Error: The configuration file "/home/runner/work/_temp/user-config-from-action.yml" is outside of the workspace

@jba
Copy link
Collaborator Author

jba commented Feb 15, 2024

@muncus suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants