Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initializing new storage control client #1865

Merged
merged 32 commits into from May 8, 2024
Merged

Initializing new storage control client #1865

merged 32 commits into from May 8, 2024

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Apr 26, 2024 •
edited

Description

  • Initializing new storage control client incase of GRPC protocol if enable-hns flag is turned on.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - Added
  3. Integration tests - Automated.

@Tulsishah Tulsishah added the execute-integration-tests Run only integration tests label Apr 26, 2024
@Tulsishah Tulsishah changed the title Storage control client Initializing new storage control client incase of GRPC protocol. Apr 26, 2024
@Tulsishah Tulsishah changed the title Initializing new storage control client incase of GRPC protocol. Initializing new storage control client incase of GRPC protocol Apr 26, 2024
@Tulsishah Tulsishah marked this pull request as ready for review April 28, 2024 04:55
@Tulsishah Tulsishah requested a review from a team as a code owner April 28, 2024 04:55
@Tulsishah Tulsishah changed the title Initializing new storage control client incase of GRPC protocol Initializing new storage control client Apr 29, 2024
@Tulsishah Tulsishah requested a review from sethiay April 29, 2024 10:09
ankitaluthra1
ankitaluthra1 requested changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@ankitaluthra1 ankitaluthra1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NA

go.mod Outdated Show resolved Hide resolved
internal/storage/storage_handle.go Outdated Show resolved Hide resolved
internal/storage/storage_handle.go Outdated Show resolved Hide resolved
internal/storage/storage_handle.go Show resolved Hide resolved
internal/storage/storage_handle.go Show resolved Hide resolved
internal/storage/storage_handle.go Show resolved Hide resolved
main.go Show resolved Hide resolved
ankitaluthra1
ankitaluthra1 previously approved these changes May 8, 2024
View reviewed changes
@Tulsishah Tulsishah requested a review from raj-prince May 8, 2024 10:22
@Tulsishah Tulsishah merged commit 4620898 into master May 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone left review comments

@raj-prince raj-prince raj-prince approved these changes

@ankitaluthra1 ankitaluthra1 ankitaluthra1 left review comments

@sethiay sethiay Awaiting requested review from sethiay

Assignees
No one assigned
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Tulsishah @tritone @raj-prince @ankitaluthra1