Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI test coverage #590

Open
gaul opened this issue Jan 24, 2022 · 1 comment
Open

Improve CI test coverage #590

gaul opened this issue Jan 24, 2022 · 1 comment
Labels
Eng-Backlog feature request Feature request: request to add new features or functionality p1 P1

Comments

@gaul
Copy link
Contributor

gaul commented Jan 24, 2022

gcsfuse could reuse s3fs tests, pjdfstest, or xfstests in CI by using fake-gcs-server. https://github.com/gaul/s3fs-fuse/tree/gcsfuse shows some partial work.
gaul added a commit to gaul/gcsfuse that referenced this issue Feb 1, 2022
@gaul
Set subtype to gcsfuse
79e274f 
This allows identifying mounts as "fuse.gcsfuse" instead of only
"fuse" on Linux.  This is useful for pjdfstest so it can exclude tests
that are not supported.  References GoogleCloudPlatform#590.
@gaul gaul mentioned this issue Feb 1, 2022
Merged
lezh pushed a commit that referenced this issue Feb 4, 2022
@gaul @lezh
Set subtype to gcsfuse
509d6c0 
This allows identifying mounts as "fuse.gcsfuse" instead of only
"fuse" on Linux.  This is useful for pjdfstest so it can exclude tests
that are not supported.  References #590.
gaul added a commit to gaul/fake-gcs-server that referenced this issue Feb 5, 2022
@gaul
Honor ListObjects IncludeTrailingDelimiter
b62998e 
This allows gcsfuse to list directory objects which end with / and
allows pjdfstest rmdir/06.t to pass.  References
GoogleCloudPlatform/gcsfuse#590.
@gaul gaul mentioned this issue Feb 5, 2022
Merged
gaul added a commit to gaul/gcsfuse that referenced this issue Feb 6, 2022
@gaul
Do not allow renaming into a non-empty directory
9e9a9f2 
This allows pjdfstest rename/20.t to pass.  References
GoogleCloudPlatform#590.
@gaul gaul mentioned this issue Feb 6, 2022
Merged
gaul added a commit to gaul/pjdfstest that referenced this issue Feb 6, 2022
@gaul
Do not test hard links with gcsfuse
1ae4a0a 
References GoogleCloudPlatform/gcsfuse#590.
@gaul gaul mentioned this issue Feb 6, 2022
Merged
lezh pushed a commit that referenced this issue Feb 6, 2022
@gaul @lezh
Do not allow renaming into a non-empty directory
cbbe567 
This allows pjdfstest rename/20.t to pass.  References
#590.
lezh added a commit that referenced this issue Feb 10, 2022
@lezh
Handle name conflicts in directory renaming
f3c29dd 
Redo #597. Required for #590.
@lezh lezh mentioned this issue Feb 10, 2022
Merged
lezh added a commit that referenced this issue Feb 10, 2022
@lezh
Handle name conflicts in directory renaming
e46f1b8 
Redo #597. Required for #590.
gaul added a commit to gaul/gcsfuse that referenced this issue Feb 11, 2022
@gaul
Run tests during CI
6467ddc 
Tests previously ran in Travis but were accidentally removed in
2dee823.  This would have prevented a
regression introduced in GoogleCloudPlatform#597.  References GoogleCloudPlatform#590.
@gaul gaul mentioned this issue Feb 11, 2022
Merged
lezh pushed a commit that referenced this issue Feb 11, 2022
@gaul @lezh
Run tests during CI
365772e 
Tests previously ran in Travis but were accidentally removed in
2dee823.  This would have prevented a
regression introduced in #597.  References #590.
gaul added a commit to gaul/fake-gcs-server that referenced this issue Feb 12, 2022
@gaul
Honor ListObjects IncludeTrailingDelimiter
b973949 
This allows gcsfuse to list directory objects which end with / and
allows pjdfstest rmdir/06.t to pass.  References
GoogleCloudPlatform/gcsfuse#590.
fsouza pushed a commit to gaul/fake-gcs-server that referenced this issue Mar 8, 2022
@gaul @fsouza
Honor ListObjects IncludeTrailingDelimiter
01b508b 
This allows gcsfuse to list directory objects which end with / and
allows pjdfstest rmdir/06.t to pass.  References
GoogleCloudPlatform/gcsfuse#590.
fsouza added a commit to fsouza/fake-gcs-server that referenced this issue Mar 8, 2022
@gaul @fsouza
Honor ListObjects IncludeTrailingDelimiter (#676)
b57a203 
* Honor ListObjects IncludeTrailingDelimiter

This allows gcsfuse to list directory objects which end with / and
allows pjdfstest rmdir/06.t to pass.  References
GoogleCloudPlatform/gcsfuse#590.

* Bump cloud.google.com/go/storage to a specific SHA

We can go back to the release version once
googleapis/google-cloud-go#5693 is merged.

Co-authored-by: francisco souza <108725+fsouza@users.noreply.github.com>
@avidullu avidullu added the feature request Feature request: request to add new features or functionality label Apr 14, 2022
@avidullu
Copy link
Contributor

#777 added the fake-gcs-server to our repo and we are already building tests around the same.

gaul added a commit to gaul/gcsfuse that referenced this issue Dec 23, 2022
@gaul
Return ENAMETOOLONG when name is too long
83fd7a2 
This allows more pjdfstests to pass.  References GoogleCloudPlatform#590.
@gaul gaul mentioned this issue Dec 23, 2022
Open
gaul added a commit to gaul/gcsfuse that referenced this issue Dec 23, 2022
@gaul
Return ENAMETOOLONG when name is too long
5d0bb5c 
This allows more pjdfstests to pass.  References GoogleCloudPlatform#590.
gaul added a commit to gaul/gcsfuse that referenced this issue Dec 23, 2022
@gaul
Return ENAMETOOLONG when name is too long
d039627 
This allows more pjdfstests to pass.  References GoogleCloudPlatform#590.
@vadlakondaswetha vadlakondaswetha removed their assignment May 22, 2023
@sethiay sethiay added the p1 P1 label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Eng-Backlog feature request Feature request: request to add new features or functionality p1 P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gaul @avidullu @sethiay @vadlakondaswetha @jasmit-s