Skip to content

Commit

Permalink
review comment
Browse files Browse the repository at this point in the history
  • Loading branch information
Tulsishah committed May 2, 2024
1 parent 0ed1587 commit f99ac90
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions internal/storage/storage_handle_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ func (testSuite *StorageHandleTest) TestNewStorageHandleWithInvalidClientProtoco

assert.NotNil(testSuite.T(), err)
assert.Nil(testSuite.T(), handleCreated)
assert.Contains(testSuite.T(), err.Error(),"invalid client-protocol requested: test-protocol")
assert.Contains(testSuite.T(), err.Error(), "invalid client-protocol requested: test-protocol")
}

func (testSuite *StorageHandleTest) TestCreateGRPCClientHandle() {
Expand Down Expand Up @@ -235,7 +235,7 @@ func (testSuite *StorageHandleTest) TestCreateGRPCClientHandle_WithHTTPClientPro

assert.NotNil(testSuite.T(), err)
assert.Nil(testSuite.T(), storageClient)
assert.Contains(testSuite.T(), err.Error(),fmt.Sprintf("client-protocol requested is not GRPC: %s", mountpkg.HTTP1))
assert.Contains(testSuite.T(), err.Error(), fmt.Sprintf("client-protocol requested is not GRPC: %s", mountpkg.HTTP1))
}

func (testSuite *StorageHandleTest) TestCreateHTTPClientHandle_WithGRPCClientProtocol() {
Expand All @@ -246,7 +246,7 @@ func (testSuite *StorageHandleTest) TestCreateHTTPClientHandle_WithGRPCClientPro

assert.NotNil(testSuite.T(), err)
assert.Nil(testSuite.T(), storageClient)
assert.Contains(testSuite.T(), err.Error(),fmt.Sprintf("client-protocol requested is not HTTP1 or HTTP2: %s", mountpkg.GRPC))
assert.Contains(testSuite.T(), err.Error(), fmt.Sprintf("client-protocol requested is not HTTP1 or HTTP2: %s", mountpkg.GRPC))
}

func (testSuite *StorageHandleTest) TestNewStorageHandleWithGRPCClientWithCustomEndpointNilAndAuthEnabled() {
Expand All @@ -273,6 +273,6 @@ func (testSuite *StorageHandleTest) TestNewStorageHandleWithGRPCClientWithCustom
handleCreated, err := NewStorageHandle(context.Background(), sc)

assert.NotNil(testSuite.T(), err)
assert.Contains(testSuite.T(), err.Error(),"GRPC client doesn't support auth for custom-endpoint. Please set anonymous-access: true via config-file.")
assert.Contains(testSuite.T(), err.Error(), "GRPC client doesn't support auth for custom-endpoint. Please set anonymous-access: true via config-file.")
assert.Nil(testSuite.T(), handleCreated)
}

0 comments on commit f99ac90

Please sign in to comment.