Skip to content

Commit

Permalink
remove flaky TestRangeReadsBeyondReadChunkSizeWithoutChunkDownloaded (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
ashmeenkaur committed Apr 29, 2024
1 parent c2f83f7 commit bf0f5b9
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
11 changes: 0 additions & 11 deletions tools/integration_tests/read_cache/range_read_test.go
Expand Up @@ -78,17 +78,6 @@ func (s *rangeReadTest) TestRangeReadsBeyondReadChunkSizeWithChunkDownloaded(t *
validateCacheSizeWithinLimit(cacheCapacityForVeryLargeFileInMiB, t)
}

func (s *rangeReadTest) TestRangeReadsBeyondReadChunkSizeWithoutChunkDownloaded(t *testing.T) {
testFileName := setupFileInTestDir(s.ctx, s.storageClient, testDirName, veryLargeFileSize, t)

expectedOutcome1 := readChunkAndValidateObjectContentsFromGCS(s.ctx, s.storageClient, testFileName, zeroOffset, t)
expectedOutcome2 := readChunkAndValidateObjectContentsFromGCS(s.ctx, s.storageClient, testFileName, offsetEndOfFile, t)

structuredReadLogs := read_logs.GetStructuredLogsSortedByTimestamp(setup.LogFile(), t)
validate(expectedOutcome1, structuredReadLogs[0], true, false, 1, t)
validate(expectedOutcome2, structuredReadLogs[1], false, false, 1, t)
}

////////////////////////////////////////////////////////////////////////
// Test Function (Runs once before all tests)
////////////////////////////////////////////////////////////////////////
Expand Down
1 change: 0 additions & 1 deletion tools/integration_tests/run_tests_mounted_directory.sh
Expand Up @@ -385,7 +385,6 @@ cleanup_test_environment
test_cases=(
"TestRangeReadTest/TestRangeReadsWithinReadChunkSize"
"TestRangeReadTest/TestRangeReadsBeyondReadChunkSizeWithChunkDownloaded"
"TestRangeReadTest/TestRangeReadsBeyondReadChunkSizeWithoutChunkDownloaded"
)
run_range_read_test_with_read_cache() {
read_cache_test_setup 500 $1 3600
Expand Down

0 comments on commit bf0f5b9

Please sign in to comment.